Hive: Fix some message typos in HiveCatalog: Matastore => Metastore #2950
Conversation
szehon-ho
changed the title
|
|
||
| } catch (TException e) { | ||
| throw new RuntimeException("Failed to create namespace " + namespace + " in Hive MataStore", e); | ||
| throw new RuntimeException("Failed to create namespace " + namespace + " in Hive MetaStore", e); |
There was a problem hiding this comment.
Out of curiosity, how do Hive folks prefer to write it? MetaStore or Metastore?
There was a problem hiding this comment.
I honestly always used Metastore and it's like that in most of the Hive docs, but I've seen the camel case a lot too.
There was a problem hiding this comment.
I’ve also always used Metastore.
Looking at this Hive design doc, it’s also Metastore with no capital S. I think this makes the most sense as it’s not really two words imo (and several Hive docs confirm it as being one word): https://cwiki.apache.org/confluence/plugins/servlet/mobile?contentId=27362072#Design-Metastore
There was a problem hiding this comment.
I'd say Metastore. Capitalizing the S was to match the class name.
kbendick
left a comment
kbendick
left a comment
There was a problem hiding this comment.
Thanks for doing this. I’m +0, only because I really feel it’s Metastore as one word and not MetaStore as two words.
I’ll let others chime in on that, but a basic search of docs etc seem to bring up Metastore as one word much more often than I’ve seen “official” docs using the phrase as two words.
|
|
||
| } catch (TException e) { | ||
| throw new RuntimeException("Failed to create namespace " + namespace + " in Hive MataStore", e); | ||
| throw new RuntimeException("Failed to create namespace " + namespace + " in Hive MetaStore", e); |
There was a problem hiding this comment.
I’ve also always used Metastore.
Looking at this Hive design doc, it’s also Metastore with no capital S. I think this makes the most sense as it’s not really two words imo (and several Hive docs confirm it as being one word): https://cwiki.apache.org/confluence/plugins/servlet/mobile?contentId=27362072#Design-Metastore
| Thread.currentThread().interrupt(); | ||
| throw new RuntimeException( | ||
| "Interrupted in call to createDatabase(name) " + namespace + " in Hive MataStore", e); | ||
| "Interrupted in call to createDatabase(name) " + namespace + " in Hive MetaStore", e); |
There was a problem hiding this comment.
If we go with Metastore and not MetaStore (which the former is correct according to a number of Hive and Cloudera docs), this also needs to be updated - plus several other locations :)
|
Yea I personally prefer Metastore as well due to Hive docs, I would guess the camel case comes originally from the Hive code itself (HiveMetaStore and HiveMetaStoreClient being the main classes..), so I didnt see the original casing as a problem. Anyway, removed camel case. |
|
Rebase to re-trigger test |
|
Test failure seemed flaky, try to fix it in : #2989 , rebase to trigger again |
5 participants
Noticed a lot of these errors while trying to debug timeouted Hive tests